Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(kuma-cp): introduce OpenTelemetry tracing #7153

Merged
merged 4 commits into from
Jun 30, 2023
Merged

feat(kuma-cp): introduce OpenTelemetry tracing #7153

merged 4 commits into from
Jun 30, 2023

Conversation

michaelbeaumont
Copy link
Contributor

@michaelbeaumont michaelbeaumont commented Jun 30, 2023 •
edited
Loading 

Span #1
    Trace ID       : ce74b2c0cb19c2bf5dc1eddb13b075c2
    Parent ID      :
    ID             : cc2c6e954782a543
    Name           : /meshes
    Kind           : SPAN_KIND_SERVER
    Start time     : 2023-06-30 13:05:27.023127684 +0000 UTC
    End time       : 2023-06-30 13:05:27.023294989 +0000 UTC
    Status code    : STATUS_CODE_UNSET
    Status message :
Attributes:
     -> http.method: STRING(GET)
     -> http.scheme: STRING(http)
     -> http.flavor: STRING(1.1)
     -> net.host.name: STRING(api-server)
     -> net.host.port: INT(5681)
     -> net.sock.peer.addr: STRING(::1)
     -> net.sock.peer.port: INT(44582)
     -> http.user_agent: STRING(HTTPie/3.2.1)
     -> http.route: STRING(/meshes)
     -> http.status_code: INT(200)

Checklist prior to review

@michaelbeaumont
feat(kuma-cp): introduce OpenTelemetry tracing
69746c7 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont
feat(kuma-cp): api server traces
2351c8d 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont michaelbeaumont marked this pull request as ready for review June 30, 2023 13:05
@michaelbeaumont michaelbeaumont requested a review from a team as a code owner June 30, 2023 13:05
@michaelbeaumont michaelbeaumont requested review from slonka and bartsmykla and removed request for a team June 30, 2023 13:05
@michaelbeaumont michaelbeaumont mentioned this pull request Jun 30, 2023
Closed
@michaelbeaumont
refactor: remove pointer, add envconfig and test
1b23e5c 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont
chore: cleanup
ff09c87 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
frzifus
frzifus approved these changes Jun 30, 2023
View reviewed changes
Copy link
Contributor

@frzifus frzifus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm :)

pkg/plugins/runtime/opentelemetry/plugin.go
ctx,
otelConfig.Endpoint,
grpc.WithTransportCredentials(
insecure.NewCredentials(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need to be configurable?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah we need to add this in another PR

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michaelbeaumont - do we have an issue for that?

@michaelbeaumont michaelbeaumont merged commit b96976f into kumahq:master Jun 30, 2023
@michaelbeaumont michaelbeaumont deleted the feat/otel-cp branch June 30, 2023 15:29
@michaelbeaumont michaelbeaumont mentioned this pull request Jul 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakubdyszkiewicz jakubdyszkiewicz jakubdyszkiewicz approved these changes

@frzifus frzifus frzifus approved these changes

@slonka slonka Awaiting requested review from slonka slonka is a code owner automatically assigned from kumahq/kuma-maintainers

@bartsmykla bartsmykla Awaiting requested review from bartsmykla bartsmykla is a code owner automatically assigned from kumahq/kuma-maintainers

@lahabana lahabana Awaiting requested review from lahabana

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@michaelbeaumont @lahabana @slonka @jakubdyszkiewicz @frzifus